Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.

Cédric Villemain <cedric.villemain.debian@gmail.com>

From: Cédric Villemain <cedric.villemain.debian@gmail.com>
To: Josh Berkus <josh@agliodbs.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-07-08T00:32:12Z
Lists: pgsql-hackers
2010/7/8 Josh Berkus <josh@agliodbs.com>:
> On 7/6/10 8:06 AM, Tom Lane wrote:
>> It might be that nobody's using any values other than 0 and -1 ...
>> in which case it wouldn't matter anyway.  I agree that the lack of
>> bug reports is notable.  But still, don't we try to avoid behavioral
>> changes in stable branches?
>
> I think most people are doing what I was doing: looking at the values in
> the logs, and writing math appropriately.  Most of the other log output
> isn't documented well, and the output values are obviously bytes, so
> frankly it never occurred to me to check the docs.

Samething here

>
> Agreed that backporting the fix to 8.3 and 8.4 is infeasible.

+1
But I don't understand why not backport a documentation patch. Thing
is identified, clearly boring for one just trusting the docs.

>
> --
>                                  -- Josh Berkus
>                                     PostgreSQL Experts Inc.
>                                     http://www.pgexperts.com
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>



-- 
Cédric Villemain               2ndQuadrant
http://2ndQuadrant.fr/     PostgreSQL : Expertise, Formation et Support