Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Magnus Hagander <magnus@hagander.net>, Andrew Dunstan <andrew@dunslane.net>
Date: 2010-07-02T16:38:56Z
Lists: pgsql-hackers
On Fri, Jul 2, 2010 at 11:07 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas <robertmhaas@gmail.com> wrote: >> On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> Robert Haas <robertmhaas@gmail.com> writes: >>>>>> This appears to have broken MinGW and Cygwin builds on the buildfarm. >>>> >>>> Well, that's not awesome. IM-ing with Magnus now. I'm wondering if >>>> this is a link-ordering problem of some kind. >>> >>> Possibly an #ifndef FRONTEND will fix it. >> >> What's failing to link is postgres.exe > > I suspect that moving copydir.c into the backend will fix this, but I > don't have an appropriate build environment to test. Can someone > please test the attached patch? Andrew confirms that this works on mingw, so I'm going to go ahead and check it in and see what happens. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company