Re: pg_subtrans keeps bloating up in the standby
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, "Kolb, Harald (NSN - DE/Munich)" <harald.kolb@nsn.com>
Date: 2010-08-27T17:17:10Z
Lists: pgsql-hackers
On Sat, Aug 28, 2010 at 2:08 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Fujii Masao <masao.fujii@gmail.com> writes: >> On Fri, Aug 27, 2010 at 11:25 PM, Heikki Linnakangas >> <heikki.linnakangas@enterprisedb.com> wrote: >>> Hmm, agreed, seems like an oversight in hot standby. Before that, we didn't >>> update pg_subtrans during recovery, so there was no point truncating it. But >>> in hot standby, we do update it, so we need to truncate it too. > >> Yes. The attached patch changes a restartpoint so that it truncates pg_subtrans >> when hot standby is enabled. > > Has StartupSUBTRANS been done? Yes. StartupXLOG calls that before bgwriter is invoked. That is, we can ensure that StartupSUBTRANS has always been done before bgwriter performs a restartpoint. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center