[PATCH] Cleanup: Compare pointers to NULL instead of 0
Marti Raudsepp <marti@juffo.org>
From: Marti Raudsepp <marti@juffo.org>
To: pgsql-hackers@postgresql.org
Date: 2010-10-29T16:25:03Z
Lists: pgsql-hackers
Attachments
- 0001-Cleanup-Compare-pointers-to-NULL-instead-of-0.patch (text/x-patch) patch 0001
Coccinelle found a few places in the code where pointer expressions were compared to 0. I have changed them to NULL instead. There was one line that I didn't dare to touch, which looks like a false positive. src/backend/regex/regc_lex.c:849: if (v->now - save == 0 || ((int) c > 0 && (int) c <= v->nsubexp)) I couldn't find the definition of v (struct vars) anywhere. Is it comparing two pointers here? Should it be "v->now == save" instead? But this code doesn't originate from PostgreSQL, so maybe it's not worth making cleanups here. Regards, Marti