Re: wip: functions median and percentile
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Hitoshi Harada <umi.tanuki@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Fetter <david@fetter.org>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2010-10-03T17:31:18Z
Lists: pgsql-hackers
Attachments
- median.diff (application/octet-stream) patch
Hello 2010/10/3 Hitoshi Harada <umi.tanuki@gmail.com>: > 2010/10/2 Pavel Stehule <pavel.stehule@gmail.com>: >> Hello >> >> updated version >> * memsort removed >> * window aggregate support blocked > > I ran this patch and it looks good for committer. > Just one thing, in src/backend/utils/adt/Makefile median.o to compile > the new file is missing. > > And I'm now thinking about how to make median happen in window > aggregate. In fact we might fix parse_func.c to distinguish the same > name aggregate and window functions and median() can be implemented > separately from aggregate one. But it's another story than this patch. > For now we can commit the median aggregate only, without window > function support. > > Regards, > Thank you very much for review fixed patch + missing Makefile Regards Pavel Stehule > > -- > Hitoshi Harada >