Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Simon Riggs <simon@2ndquadrant.com>, Florian Pflug <fgp@phlo.org>, Robert Haas <rhaas@postgresql.org>, pgsql-hackers@postgresql.org
Date: 2010-06-25T13:15:18Z
Lists: pgsql-hackers
Attachments
- libpq-keepalive-docs.patch (application/octet-stream) patch
On Thu, Jun 24, 2010 at 11:50 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> On Thu, Jun 24, 2010 at 1:38 PM, Simon Riggs <simon@2ndquadrant.com> wrote: >>> On Thu, 2010-06-24 at 11:15 -0400, Tom Lane wrote: >>>> It might be a good idea to add a sentence to the documentation, though, >>>> just pointing out that these control client-side keepalive probes rather >>>> than server-side. >>> >>> Yes please. I was confused; I think others will be also. > >> Do either of you have any thoughts about where would be the best place >> to add such a sentence? > > In the hunk you added to libpq.sgml would be fine by me. Well, the trick is that the hunk that I added is really four separate sections, and adding a whole sentence to each one seems like overkill. Here's an attempt at rewording the sections so that the information is included in each parameter's description without taking up a whole sentence. Thoughts? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company