Horton
Menu

Re: multibyte-character aware support for function "downcase_truncate_identifier()"

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Rajanikant Chirmade <rajanikant.chirmade@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2010-11-21T21:14:48Z
Lists: pgsql-hackers 
On Wed, Jul 7, 2010 at 10:07 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Rajanikant Chirmade <rajanikant.chirmade@enterprisedb.com> writes:
>> Every identifier is downcase & truncated by function
>> "downcase_truncate_identifier()"
>> before using it.
>
>> But since the function "downcase_truncate_identifier()" is not
>> multibyte-charecter aware,
>> it is not able to downcase some of special charecters in identifier like
>> "my_SchemÄ".
>
> IIRC this is intentional.  Please consult the archives for previous
> discussions.

Why would this be intentional?

One concern I have about this approach is that I am guessing that the
current implementation of str_tolower() is a lot slower than the
current implementation of downcase_truncate_identifier().  It would be
nice to have an implementation that is capable of handling wide
characters but doesn't actually incur the speed penalty unless a wide
character is actually present.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Implement a solution to the 'Turkish locale downcases I incorrectly'