Re: log_hostname and pg_stat_activity
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Steve Singer <ssinger_pg@sympatico.ca>, pgsql-hackers@postgresql.org
Date: 2011-02-01T18:33:56Z
Lists: pgsql-hackers
On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentraut <peter_e@gmx.net> wrote: > On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote: >> However if I connect with a line in pg_hba that matches on an IP >> network then my client_hostname is always null unless log_hostname is >> set to true. This is consistent with the behavior you describe but I >> think the average user will find it a bit confusing. Having a column >> that is always null unless a GUC is set is less than ideal but I >> understand why log_hostname isn't on by default. > > Well, we have all these track_* variables, which also control what > appears in the statistics views. > > After thinking about this some more, I think it might be better to be > less cute and forget about the interaction with the pg_hba.conf hostname > behavior. That is, the host name is set if and only if log_hostname is > on. +1 for doing it that way. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company