Re: setlocale and gettext in Postgres

Magnus Hagander <magnus@hagander.net>

From: Magnus Hagander <magnus@hagander.net>
To: Dave Page <dpage@pgadmin.org>
Cc: Itagaki Takahiro <itagaki.takahiro@gmail.com>, Hiroshi Inoue <inoue@tpf.co.jp>, PG Hackers <pgsql-hackers@postgresql.org>
Date: 2011-02-01T08:29:34Z
Lists: pgsql-hackers
On Tue, Feb 1, 2011 at 09:08, Dave Page <dpage@pgadmin.org> wrote:
> On Tue, Feb 1, 2011 at 5:36 AM, Itagaki Takahiro
> <itagaki.takahiro@gmail.com> wrote:
>> 2011/1/27 Hiroshi Inoue <inoue@tpf.co.jp>:
>>> I see now the following lines in libintl.h of version
>>> 0.18.1.1 which didn't exist in 0.17 version.
>>>
>>> The macro may cause a trouble especially on Windows.
>>> Attached is a patch to disable the macro on Windows.
>>
>> Can anyone test the fix?
>>
>> I added the patch to the current commitfest for reminder.
>> https://commitfest.postgresql.org/action/patch_view?id=528
>
> The QA team in EDB have tested the patch for me. It works as designed
> and allows us to upgrade gettext to fix Japanese localisation on
> Win64. Upgrading gettext without the patch will fix Japanese, but
> break other translations (eg. French).

Do we need to backpatch this?


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/