Re: Fw: patch for pg_ctl.c to add windows service start-type
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Quan Zongliang <quanzongliang@gmail.com>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, David Fetter <david@fetter.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-08-20T09:21:18Z
Lists: pgsql-hackers
On Fri, Aug 20, 2010 at 01:01, Quan Zongliang <quanzongliang@gmail.com> wrote: > Because Windows's CreateService has serial start-type: > SERVICE_AUTO_START > SERVICE_BOOT_START > SERVICE_DEMAND_START > SERVICE_DISABLED > SERVICE_SYSTEM_START > > Although all of them are not useful for pg service. > I think it is better to use enum. I don't see us ever using anything other than auto or demand. The others aren't for "regular services", except for "disabled". And adding a disabled service makes no sense :-) So I'm with Alvaro, I think it's a good idea to simplify that. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/