Re: I: About "Our CLUSTER implementation is pessimal" patch

Itagaki Takahiro <itagaki.takahiro@gmail.com>

From: Itagaki Takahiro <itagaki.takahiro@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Leonardo Francalanci <m_lists@yahoo.it>, Josh Kupershmidt <schmiddy@gmail.com>, pgsql-hackers@postgresql.org

Date: 2010-10-08T05:47:57Z

Lists: pgsql-hackers

On Fri, Oct 8, 2010 at 10:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
>> I wrote a patch to improve CLUSTER VERBOSE (and VACUUM FULL VERBOSE).
>> The patch should be applied after sorted_cluster-20100721.patch .
>
> Applied with minor fixes; in particular, I think you got the effects of
> rewrite_heap_dead_tuple backwards.  When a tuple is removed from
> unresolved_tups, that amounts to changing its status from "recently
> dead" to "dead and will not be written out".

Ah, yes. I misunderstood the behavior. Thanks for the fix!

-- 
Itagaki Takahiro