Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch

Dean Rasheed <dean.a.rasheed@gmail.com>

From: Dean Rasheed <dean.a.rasheed@gmail.com>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Bernd Helmle <mailings@oopsware.de>, Robert Haas <robertmhaas@gmail.com>, Andrew Geery <andrew.geery@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2010-10-14T19:47:27Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Catalog NOT NULL constraints
- e056c557aef4 16.0 landed

Attachments

notnull_constraint2.patch (application/octet-stream) patch

On 14 October 2010 20:28, Alvaro Herrera <alvherre@commandprompt.com> wrote:
>> Looking in that function, there is a similar "found" variable that
>> isn't being initialised (which my compiler didn't warn about).
>> Initialising that to false, sems to fix the problem and all the
>> regression tests then pass.
>
> Excellent.  Please send an updated patch.
>

OK, here it is.

I've not cured this compiler warning (in fact I'm not sure what it's
complaining about, because the variable *is* used):

tablecmds.c: In function 'ATExecSetNotNull':
tablecmds.c:4747: warning: unused variable 'is_new_constraint'

Regards,
Dean