Re: pg_primary_conninfo
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-12-28T13:39:37Z
Lists: pgsql-hackers
On Tue, Dec 28, 2010 at 14:38, Robert Haas <robertmhaas@gmail.com> wrote: > On Tue, Dec 28, 2010 at 8:31 AM, Magnus Hagander <magnus@hagander.net> wrote: >> Attached patch implements a function called pg_primary_conninfo() that >> returns, well, the primary_conninfo used on the standby when in >> streaming replication mode (otherwise NULL). > > +1. Let's make sure to explicitly document what this function returns > when recovery was previous in progress, but we are now in normal > running. Oh, didn't think of that scenario. Is that intended behaviour though? I tend to think that it is (since you can check with pg_is_in_recovery) as long as it's documented, but might it make more sense to have it return NULL in this case? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/