Re: pg_dump -X

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Bruce Momjian <bruce@momjian.us>

Cc: Alvaro Herrera <alvherre@commandprompt.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2011-03-12T05:19:04Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

The -X option in pg_dump was supposed to be a workaround for the lack of
- 2b25e1169f44 8.2.0 cited

On Fri, Mar 11, 2011 at 10:36 PM, Bruce Momjian <bruce@momjian.us> wrote:
> Alvaro Herrera wrote:
>> Excerpts from Bruce Momjian's message of vie mar 11 00:59:03 -0300 2011:
>>
>> > > At a minimum, we should probably also remove -X no-security-label and
>> > > -X no-unlogged-table-data, which don't exist in any released versions
>> > > (unless you want to count alphas).  But considering that this has been
>> > > deprecated and undocumented since 8.2, I think it might be time to
>> > > pull the plug on -X altogether.
>> >
>> > I remove the new -X options with the attached, applied patch.  The
>> > existing options are not really costing us anything except a few lines
>> > of code.
>>
>> Given that, it seems pretty pointless to remove support for -X options
>> that have existed for years.
>
> I agree.  They are not documented and only are a few C lines.

Presumably the point of deprecating the feature is that we'd
eventually remove it.  If 4 major releases isn't long enough, what is?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company