Horton

Re: Change pg_last_xlog_receive_location not to move backwards

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>, Jeff Janes <jeff.janes@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-02-15T12:41:37Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Typo fixes. receivedUpto should be capitalized consistently.

On Tue, Feb 15, 2011 at 12:34 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> You suggest that the shared variable Stream tracks the WAL write location,
> after it's set to the replication starting position? I don't think
> that the write
> location needs to be tracked in the shmem because other processes than
> walreceiver don't use it.

Well, my proposal was to expose it, on the theory that it's useful.
As we stream the WAL, we write it, so I think for all intents and
purposes write == stream.  But using it to convey the starting
position makes more sense if you call it stream than it does if you
call it write.

> You propose to rename LogstreamResult.Write to .Stream, and
> merge it and receiveStart?

Yeah, or probably change recieveStart to be called Stream.  It's
representing the same thing, just in shmem instead of backend-local,
so why name it differently?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company