Re: pgsql: Add TCP keepalive support to libpq.

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Kevin Grittner <Kevin.Grittner@wicourts.gov>, Simon Riggs <simon@2ndquadrant.com>, Florian Pflug <fgp@phlo.org>, pgsql-hackers@postgresql.org, Robert Haas <rhaas@postgresql.org>

Date: 2010-06-25T17:08:31Z

Lists: pgsql-hackers

On Fri, Jun 25, 2010 at 1:02 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "Kevin Grittner" <Kevin.Grittner@wicourts.gov> writes:
>> Robert Haas <robertmhaas@gmail.com> wrote:
>>> Here's an attempt at rewording the sections so that the
>>> information is included in each parameter's description without
>>> taking up a whole sentence.
>>>
>>> Thoughts?
>
>> It makes the point without beating one over the head with it.  I
>> particularly like the way this patch moves the main point of the
>> parameter to the front, with all the conditions under which it might
>> be ignored pushed farther back.  It reads much better that way, at
>> least for me.
>
> Looks good to me too.

OK, committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company