Re: Visual Studio 2010/Windows SDK 7.1 support
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Brar Piening <brar@gmx.de>
Cc: pgsql-hackers@postgresql.org
Date: 2011-01-05T17:33:32Z
Lists: pgsql-hackers
On Mon, Jan 3, 2011 at 16:45, Brar Piening <brar@gmx.de> wrote: > On Mon, 3 Jan 2011 10:44:19 +0100, Magnus Hagander <magnus@hagander.net> > wrote: >> >> Yeah, it looks that way - it's missing the ordering of the contrib >> I'll run it once for that now, and then please rebase your >> patch on top of that - makes it easier to review it. > > The rebased patch can be grabbed from http://www.piening.info/VS2010v2.patch Thanks. It still has windows linebreaks, but only once now, so they can be properly removed by patch. It applies cleanly now. > It's actually the same patch as before with the corrupted line-endings > parsed out. > > "git diff master VS2010 > ../VS2010.patch" reproduceabyl generates those on > my (windows) system when I use git-external-diff configured as described in > http://wiki.postgresql.org/wiki/Working_with_Git#Context_diffs_with_Git to > produce context diffs. Yeah, I'm not sure those instructions really take Windows into account :-) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/