Horton

Re: REVIEW: Determining client_encoding from client locale

Ibrar Ahmed <ibrar.ahmad@gmail.com>

View thread
From: Ibrar Ahmed <ibrar.ahmad@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Peter Eisentraut <peter_e@gmx.net>, Jaime Casanova <jaime@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Date: 2011-02-08T10:05:40Z
Lists: pgsql-hackers

Attachments

Stephen Frost!

I have modified the code to use ADD_STARTUP_OPTION instead of writing code
again.
And  tried the patch on Windows  and Linux and it works for me.




On Sun, Feb 6, 2011 at 10:19 AM, Stephen Frost <sfrost@snowman.net> wrote:

> Ibrar,
>
> * Ibrar Ahmed (ibrar.ahmad@gmail.com) wrote:
> > I have reviewed/tested this patch.
>
> Great, thanks for that!
>
> > In my point code should be like this
> >
> >      *if (conn->client_encoding_initial &&
> conn->client_encoding_initial[0])
> >        {
> >                if (packet)
> >                {
> >                        strcpy(packet + packet_len, "client_encoding");
> >                        packet_len += strlen("client_encoding") + 1;
> >                        strcpy(packet + packet_len,
> > conn->client_encoding_initial);
> >                        packet_len +=
> strlen(conn->client_encoding_initial) +
> > 1;
> >               }
> >         }*
>
> Makes sense to me, just reading through this email.  Have you tested
> this change..?  Could you provide it as an additional patch or a new
> patch including the change against head, assuming it still works well in
> your testing?
>
> > I will test this patch on Windows and will send results.
>
> That would be great, it's not easy for me to test under Windows.
>
>        Thanks!
>
>                Stephen
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAk1O5joACgkQrzgMPqB3kijODgCeN1/PVKf/qzeuWOz82FwpR/B0
> 2rMAnR+4tCxNp9eZn7qIOTXqCv70H2oC
> =vYXv
> -----END PGP SIGNATURE-----
>
>


-- 
   Ibrar Ahmed