Horton

Re: multiset patch review

Itagaki Takahiro <itagaki.takahiro@gmail.com>

View thread
From: Itagaki Takahiro <itagaki.takahiro@gmail.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2011-01-12T04:52:12Z
Lists: pgsql-hackers

Attachments

Thank you for the review.

On Mon, Jan 10, 2011 at 04:13, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> regress tests failed
Fixed.

> There is often used a fragment
> + <----><------>fn.arg[0] = values1[n1];
> + <----><------>fn.arg[1] = values2[n2];
> + <----><------>fn.argnull[0] = false;
> + <----><------>fn.argnull[1] = false;
> + <----><------>fn.isnull = false;
> + <----><------>r = DatumGetInt32(FunctionCallInvoke(&fn));
> it can be moved to procedure?

Agreed. I use FunctionCall2() instead of the fragments.

> I see only one issue. There isn't documented, what is a MULTISET?

I added a short description about MULTISET and example of operators
in "Arrays > 8.14.7. Multiset Support" section in the docs.
Is it enough? or what kind of information do you want?

Separate patches for src and doc attached. It includes a few bug fixes
and cleanup. I changed the error code in trim_array() to
ERRCODE_ARRAY_ELEMENT_ERROR according to the spec.

-- 
Itagaki Takahiro