Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Jan Urbański <wulczer@wulczer.org>, pgsql-hackers@postgresql.org, Shigeru HANADA <hanada@metrosystems.co.jp>

Date: 2010-12-26T20:27:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add foreign data wrapper error code values for SQL/MED.
- 85cff3ce7f36 9.1.0 cited

On Sun, Dec 26, 2010 at 12:17 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Proposed patch attached.  This adds what I believe to be the correct
>> incantations to errcodes.sgml and plerrcodes.h, and also corrects a
>> typographical error in yesterday's commit which I failed to notice
>> while reviewing.
>
> Hmm.  Even with the typo fixed, ERRCODE_FDW_UNABLE_TO_CREATE_EXECUTION
> seems pretty darn opaque.  Is it missing a word?  Can we rephrase it so
> people will have some idea what it means?

(looks at a draft copy of the spec)

Appears to be straight out of the spec.  There's also some
incomprehensible (to me) language explaining what it's supposed to
mean.  I think they're using the term "FDW execution" to mean
something along the lines of "an instance of grabbing data via an
FDW".  Or something sort of vaguely like that.  If I didn't know
better I'd think this had been deliberately obfuscated.

At any rate, I think rewording language straight out of the spec is
likely a bad plan.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company