Horton

Re: Sync Rep for 2011CF1

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2011-02-14T05:25:57Z
Lists: pgsql-hackers 
On Fri, Feb 11, 2011 at 4:06 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> I added a XLogWalRcvSendReply() call into XLogWalRcvFlush() so that it also
> sends a status update every time the WAL is flushed. If the walreceiver is
> busy receiving and flushing, that would happen once per WAL segment, which
> seems sensible.

This change can make the callback function "WalRcvDie()" call ereport(ERROR)
via XLogWalRcvFlush(). This looks unsafe.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center