Re: multiset patch review

Itagaki Takahiro <itagaki.takahiro@gmail.com>

From: Itagaki Takahiro <itagaki.takahiro@gmail.com>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2011-01-13T01:40:49Z

Lists: pgsql-hackers

On Wed, Jan 12, 2011 at 23:29, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> Two small nitpicks:
> + check_concatinatable(Oid element_type1, Oid element_type2)
> +         ereport(ERROR,
> +                 (errcode(ERRCODE_DATATYPE_MISMATCH),
> +                  errmsg("cannot concatenate incompatible arrays"),
> +                  errdetail("Arrays with element types %s and %s are not "
> +                            "compatible for concatenation.",
>
> I think the word is either "concatenable" or "concatenatable".  Also
> please don't break up the string in errdetail() even if it's longer than
> 80 chars.  (The function below this one has this too)

OK, I'll fix them,
but the broken up messages come from the existing code.

-- 
Itagaki Takahiro