Re: refactoring comment.c
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: KaiGai Kohei <kaigai@kaigai.gr.jp>, pgsql-hackers@postgresql.org
Date: 2010-08-19T01:32:48Z
Lists: pgsql-hackers
Attachments
- refactor_comment-v3.patch (application/octet-stream) patch v3
On Tue, Aug 17, 2010 at 2:49 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> On Tue, Aug 17, 2010 at 2:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> I don't insist that the separation has to be crisp. I'm merely saying >>> that putting a large chunk of useful-only-at-execution-time code into >>> backend/parser is the Wrong Thing. > >> OK, but there should be a reason for that. For example, if there are >> circumstances when we parse a statement, and then time passes, and >> then we execute it later, that's a good argument for what you're >> saying here. > > Yeah, and that's exactly what happens with utility statements that (for > example) get into the plan cache. OK. I'll have to look through that code some time. Here's v3. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company