Re: review: FDW API

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

Cc: Shigeru HANADA <hanada@metrosystems.co.jp>, Jan Urbański <wulczer@wulczer.org>, Postgres - Hackers <pgsql-hackers@postgresql.org>

Date: 2011-01-30T19:42:02Z

Lists: pgsql-hackers

On Mon, Jan 24, 2011 at 8:08 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
>> How much review have you done of parts (3) and (4)?  The key issue for
>> all of the FDW work in progress seems to be what the handler API is
>> going to look like, and so once we get that committed it will unblock
>> a lot of other things.
>
> I've gone through the code in a bit more detail now. I did a bunch of
> cosmetic changes along the way, patch attached. I also added a few
> paragraphs in the docs. We need more extensive documentation, but this at
> least marks the places where I think the docs need to go.
>
> Comments:

I haven't seen any responses to these comments.  Time grows short to
get this committed to PostgreSQL 9.1.  We need responses to these
comments and an updated patch ASAP.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company