Re: RecordTransactionCommit() and SharedInvalidationMessages

Robert Haas <robertmhaas@gmail.com>

View thread

From: Robert Haas <robertmhaas@gmail.com>

To: Fujii Masao <masao.fujii@gmail.com>

Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, pgsql-hackers@postgresql.org

Date: 2010-08-13T01:24:50Z

Lists: pgsql-hackers

Attachments

record_transaction_commmit-v2.patch (application/octet-stream) patch v2

On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>>>> It appears to me that RecordTransactionCommit() only needs to WAL-log
>>>>> shared invalidation messages when wal_level is hot_standby, but I
>>>>> don't see a guard to prevent it from doing it in all cases.
[...]
>>> The fix looks pretty simple (see attached), although I don't have any
>>> clear idea how to test it.
>> Should use XLogStandbyInfoActive() macro, for the sake of consistency.
> And, RelcacheInitFileInval should be initialized with false just in case.

How about this?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company