Re: sepgsql contrib module

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: KaiGai Kohei <kaigai@ak.jp.nec.com>

Cc: KaiGai Kohei <kaigai@kaigai.gr.jp>, PgHacker <pgsql-hackers@postgresql.org>

Date: 2011-01-26T15:25:15Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgindent run for 9.0, second run
- 239d769e7e05 9.0.0 cited

2011/1/25 KaiGai Kohei <kaigai@ak.jp.nec.com>:
> (2011/01/26 12:23), KaiGai Kohei wrote:
>>>> Yikes.  On further examination, exec_object_restorecon() is pretty
>>>> bogus.  Surely you need some calls to quote_literal_cstr() in there
>>>> someplace.
>>>
>> Are you concerning about the object name being supplied to
>> selabel_lookup_raw() in exec_object_restorecon()?
>> I also think this quoting you suggested is reasonable.
>>
> How about the case when the object name only contains alphabet and
> numerical characters?

Oh, quote_literal_cstr() is the wrong function - these are
identifiers, not literals.  So we should use quote_identifier().

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company