Re: wip: functions median and percentile

Pavel Stehule <pavel.stehule@gmail.com>

From: Pavel Stehule <pavel.stehule@gmail.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Hitoshi Harada <umi.tanuki@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, David Fetter <david@fetter.org>

Date: 2010-09-21T21:03:31Z

Lists: pgsql-hackers

Attachments

median.diff (text/x-patch) patch

2010/9/21 Robert Haas <robertmhaas@gmail.com>:
> On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
>>> * Cosmetic coding style should be more appropriate, including trailing
>>> white spaces and indentation positions.
>>
>> can you specify where, please?
>
> I noticed a lot of problems in this area when working on your \ef /
> \sf patch, too.  Trailing whitespace is nearly always bad, and it's
> not hard to find - just grep the diff for it.  As for indentation, try
> to match the surrounding code.

is updated patch better?

Pavel

>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise Postgres Company
>