Re: warning message in standby
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Dimitri Fontaine <dfontaine@hi-media.com>, Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-06-14T16:49:30Z
Lists: pgsql-hackers
On Mon, Jun 14, 2010 at 12:31 PM, Simon Riggs <simon@2ndquadrant.com> wrote: >> If that's the case, I guess Tom's right, once more, saying that LOG is >> fine here. If we want to be more subtle than that, we'd need to revise >> each and every error message and attribute it the right level, which it >> probably have already anyway. > > Nobody is arguing with what Tom has said about log levels. Agreed. > The problem is that LOG already has many things like performance logging > which aren't a problem as all. So we need a level between LOG and FATAL > to draw anyone's attention. Not sure I agree with this - what I think the problem is here is we need to make a clear distinction between recoverable errors and unrecoverable errors. > @Robert - I'd point out that the behaviour of archive_cleanup_command > and recovery_end_command is broken as a result of this discussion. :-( How so? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company