Re: Add ENCODING option to COPY

Hitoshi Harada <umi.tanuki@gmail.com>

View thread

From: Hitoshi Harada <umi.tanuki@gmail.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Itagaki Takahiro <itagaki.takahiro@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-01-31T15:07:19Z

Lists: pgsql-hackers

Attachments

copy_encoding.v2.patch (application/octet-stream) patch v2

2011/1/31 Hitoshi Harada <umi.tanuki@gmail.com>:
> 2011/1/31 Robert Haas <robertmhaas@gmail.com>:
>> On Tue, Jan 25, 2011 at 10:24 AM, Hitoshi Harada <umi.tanuki@gmail.com> wrote:
>>> I'll check the code more if we have better alternatives.
>>
>> Where are we with this?
>
> I'll post another version today.

Here's the patch.

Finally I concluded the concern Itagaki-san raised can be solved by
adding code that restores client_encoding in copy_in_error_callback. I
tested some encoding mismatch cases with this patch and saw
appropriate messages in NLS environment.

Regards,

-- 
Hitoshi Harada