Re: I: About "Our CLUSTER implementation is pessimal" patch
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Itagaki Takahiro <itagaki.takahiro@gmail.com>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, Josh Kupershmidt <schmiddy@gmail.com>, Leonardo Francalanci <m_lists@yahoo.it>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-09-29T13:14:13Z
Lists: pgsql-hackers
On Wed, Sep 29, 2010 at 1:12 AM, Itagaki Takahiro <itagaki.takahiro@gmail.com> wrote: > On Wed, Sep 29, 2010 at 1:27 PM, Alvaro Herrera > <alvherre@commandprompt.com> wrote: >>> I see a consistent >>> ~10% advantage for the sequential scan clusters. >> >> 10% is nothing. I was expecting this patch would give an order of >> magnitude of improvement or somethine like that in the worst cases of >> the current code (highly unsorted input) > > Yes. It should be x10 faster than ordinary method in the worst cases. > > I have a performance result of pg_reorg, that performs as same as > the patch. It shows 16 times faster than the old CLUSTER. In addition, > it was slow if not fragmented. (So, it should not be "consistent".) > http://reorg.projects.postgresql.org/ Can you reproduce that with this patch? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company