Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Itagaki Takahiro <itagaki.takahiro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2010-11-01T03:10:53Z
Lists: pgsql-hackers
On Sun, Oct 31, 2010 at 11:04 PM, Itagaki Takahiro <itagaki.takahiro@gmail.com> wrote: > On Mon, Nov 1, 2010 at 6:41 AM, Andres Freund <andres@anarazel.de> wrote: >> While looking at binary COPY performance I forgot to add BINARY and was a bit >> shocked to see printf that high in the profile... >> >> A change from 9192.476ms 5309.928ms seems to be pretty good indication that a >> change in that area is waranted given integer columns are quite ubiquous... > > Good optimization. Here is the result on my machine: > * before: 13057.190 ms, 12429.092 ms, 12622.374 ms > * after: 8261.688 ms, 8427.024 ms, 8622.370 ms Wow. Nice stuff, Andres! -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company