Re: [PATCH] Add SIGCHLD catch to psql
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: David Fetter <david@fetter.org>
Cc: Bruce Momjian <bruce@momjian.us>, Stephen Frost <sfrost@snowman.net>, pgsql-hackers@postgresql.org
Date: 2010-05-15T23:58:49Z
Lists: pgsql-hackers
On Sat, May 15, 2010 at 7:46 PM, David Fetter <david@fetter.org> wrote: >> > Anyway, this makes FETCH_COUNT alot more useful, and, in my view, the >> > current behaviour of completely ignoring $PAGER exiting is a bug. >> >> Plesae add this to the next commit-fest: >> >> https://commitfest.postgresql.org/action/commitfest_view/inprogress >> >> Thanks. > > Wouldn't this count as a bug fix? Possibly, but changes to signal handlers are pretty global and can sometimes have surprising side effects. I'm all in favor of someone reviewing the patch - any volunteers? One case to test might be reading input from a file that contains \! escapes. More generally, we need to consider every way that psql can get SIGCHLD and think about whether this is the right behavior. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company