Re: sepgsql contrib module

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: KaiGai Kohei <kaigai@ak.jp.nec.com>

Cc: KaiGai Kohei <kaigai@kaigai.gr.jp>, PgHacker <pgsql-hackers@postgresql.org>

Date: 2011-01-24T03:49:08Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgindent run for 9.0, second run
- 239d769e7e05 9.0.0 cited

On Sun, Jan 23, 2011 at 9:56 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Sun, Jan 23, 2011 at 8:53 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> 2011/1/21 KaiGai Kohei <kaigai@ak.jp.nec.com>:
>>> The attached patch is a revised version.
>>
>> I've committed this.  Cleanup coming...
>
> Yikes.  On further examination, exec_object_restorecon() is pretty
> bogus.  Surely you need some calls to quote_literal_cstr() in there
> someplace.  And how about using getObjectDescriptionOids() for the
> error message, instead of the entirely bogus construction that's there
> now?

Also, shouldn't a bunch of these messages end in ": %m"?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company