Horton

Re: auto-sizing wal_buffers

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Greg Smith <greg@2ndquadrant.com>, Fujii Masao <masao.fujii@gmail.com>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org
Date: 2011-01-23T02:52:18Z
Lists: pgsql-hackers 
On Sat, Jan 22, 2011 at 9:42 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>>> Oh, you're complaining about SetConfigOption, not the assign hooks.
>
>> I was actually complaining about the latter, and then switched gears
>> to the former.  I'm an equal-opportunity complainer today, I guess...
>
> It does strike me that we could provide SetConfigOptionInt,
> SetConfigOptionBool, and SetConfigOptionReal for the benefit of callers
> who'd prefer to pass values in those formats.  They'd still do sprintf
> internally, but this would make the call sites a bit cleaner.

Why do we need to double the conversion in the first place?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company