Horton

Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Jan Urbański <wulczer@wulczer.org>
Cc: Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>, Josh Berkus <josh@agliodbs.com>, pgsql-hackers@postgresql.org
Date: 2011-03-02T13:25:08Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Further refine patch for commenting operator implementation functions.

  2. Fix citext's upgrade-from-unpackaged script to set its collation correctly.

  3. Mark operator implementation functions as such in their comments.

  4. Add KNNGIST support to contrib/btree_gist.

  5. Fix plpython breakage detected on certain Fedora machines on buildfarm.

On Wed, Mar 2, 2011 at 6:14 AM, Jan Urbański <wulczer@wulczer.org> wrote:
>> That seems to have fixed it, so I have applied the patch. Would you like
>> to supply some comments to got with it?
>
> The comment would be something like
>
> /* XXX it appears that in some circumstantes the reference count of the
> spiexceptions module drops to zero causing a Python assert failure when
> the garbage collector visits the module. This has been observed on the
> buildfarm. To fix this, add an additional ref for the module here. */
>
> I have no idea why the refcount of the module becomes zero, debug prints
> I added on my system were always showing 1.

But does bumping the ref count then create a leak the rest of the time?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company