Horton

Re: pl/python refactoring

Hitoshi Harada <umi.tanuki@gmail.com>

View thread
From: Hitoshi Harada <umi.tanuki@gmail.com>
To: Jan Urbański <wulczer@wulczer.org>
Cc: Peter Eisentraut <peter_e@gmx.net>, Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2011-01-19T10:56:29Z
Lists: pgsql-hackers 
2011/1/19 Jan Urbański <wulczer@wulczer.org>:
> On 19/01/11 02:06, Hitoshi Harada wrote:
>> - -1 is used as the initial value of PLyTypeInfo.is_rowtype. Why not 0?
>
> See the comments in struct PLyTypeInfo:
>
> is_rowtype can be: -1 = not known yet (initial state); 0 = scalar
> datatype; 1 = rowtype; 2 = rowtype, but I/O functions not set up yet

Well, I mean that 0 = inital, 1 = scalar, 2 = rowtype, 3 = rowtype but
not set up sounds more intuitive to me. Of course this is only what I
feel.

Regards,


-- 
Hitoshi Harada