Re: pg_execute_from_file review
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, Joshua Tolley <eggyknap@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-11-29T15:51:43Z
Lists: pgsql-hackers
On Mon, Nov 29, 2010 at 10:37 AM, Andrew Dunstan <andrew@dunslane.net> wrote: > > > On 11/29/2010 10:30 AM, Robert Haas wrote: >> >> On Mon, Nov 29, 2010 at 10:27 AM, Robert Haas<robertmhaas@gmail.com> >> wrote: >>> >>> On Mon, Nov 29, 2010 at 4:26 AM, Dimitri Fontaine >>> <dimitri@2ndquadrant.fr> wrote: >>>>> >>>>> * I'd like to ask native speakers whether "from" is needed in names >>>>> of "pg_execute_from_file" and "pg_execute_from_query_string". >>>> >>>> Fair enough, will wait for some comments before producing a v6. >>> >>> Yes, you need the from there. >> >> Eh, wait. You definitely need from in pg_execute_from_file(). But >> pg_execute_from_query_string() doesn't sound quite right. What does >> that function do, anyway? > > I'm not sure why you need either "from". It just seems like a noise word. > Maybe we could use pg_execute_query_file() and pg_execute_query_string(), > which would be fairly clear and nicely symmetrical. Because you execute queries, not files. Or at least that's how I think about it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company