Re: multiset patch review

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Itagaki Takahiro <itagaki.takahiro@gmail.com>

Cc: Stephen Frost <sfrost@snowman.net>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2011-02-16T15:38:43Z

Lists: pgsql-hackers

On Tue, Feb 15, 2011 at 7:13 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Feb 15, 2011 at 4:31 AM, Itagaki Takahiro
> <itagaki.takahiro@gmail.com> wrote:
>> array_flatten() no longer exists. I added array_trim() as an alias
>> to trim_array() because it would be a FAQ.
>
> I don't like the alias thing - let's add one name or the other, not both.
>
> Similarly, let's NOT add array_union_all as an alias for array_concat.
>
> 'cannot use multi-dimensional arrays' reads awkwardly to me.  I think
> it should say something like "sorting of multi-dimensional arrays is
> not supported".
>
> multi-demensional -> multi-dimensional
>
> slaces -> slices
>
> The formula in the trim_array comment is apparently misparenthesized.

I think we're out of time to keep bikeshedding this.  Let's revisit it for 9.2.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company