Re: psql: Add \dL to show languages
Josh Kupershmidt <schmiddy@gmail.com>
From: Josh Kupershmidt <schmiddy@gmail.com>
To: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Fernando Ike <fike@midstorm.org>
Date: 2011-01-19T00:34:41Z
Lists: pgsql-hackers
Attachments
- psql_languages.v8.patch (text/x-patch) patch v8
On Tue, Jan 18, 2011 at 1:35 PM, Andreas Karlsson <andreas@proxel.se> wrote: > Hi Josh, > > Nope, I do not have any better ideas than "DO Blocks?". > > Everything looks good with the exception one bug now. > > \dL foo > ********* QUERY ********** > SELECT l.lanname AS "Name", > pg_catalog.pg_get_userbyid(l.lanowner) as "\Owner", > l.lanpltrusted AS "Trusted" > FROM pg_catalog.pg_language lWHERE l.lanname ~ '^(foo)$' > > ORDER BY 1; > ************************** > > ERROR: syntax error at or near "l" > LINE 4: FROM pg_catalog.pg_language lWHERE l.lanname ~ '^(foo)$' > > > I believe the fix is to move \n from before the WHERE clause to after > the FROM, and from before ORDER BY to after WHERE. Whoops, good you caught that. Should be fixed now. > Fix this bug and I believe this patch is ready for a committer. > > PS. You added some trailing withspace after printACLColumn, A > recommendation if you want to avoid it is to either have a git commit > hook which checks for that and/or have colouring of git diffs so you can > see it marked in red. I use both. :) Got that now too. I lost my ~/.emacs file recently, which is mostly why I'm making whitespace mistakes. Rebuilding slowly though; (setq-default show-trailing-whitespace t) is what I needed. I left the "Call Handler" and "Validator" columns in the verbose output since I haven't heard otherwise. Josh