Re: pg_execute_from_file review

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Dimitri Fontaine <dimitri@2ndquadrant.fr>

Cc: Itagaki Takahiro <itagaki.takahiro@gmail.com>, Joshua Tolley <eggyknap@gmail.com>, pgsql-hackers@postgresql.org

Date: 2010-11-29T15:30:02Z

Lists: pgsql-hackers

On Mon, Nov 29, 2010 at 10:27 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Mon, Nov 29, 2010 at 4:26 AM, Dimitri Fontaine
> <dimitri@2ndquadrant.fr> wrote:
>>> * I'd like to ask native speakers whether "from" is needed in names
>>>   of "pg_execute_from_file" and "pg_execute_from_query_string".
>>
>> Fair enough, will wait for some comments before producing a v6.
>
> Yes, you need the from there.

Eh, wait.  You definitely need from in pg_execute_from_file().  But
pg_execute_from_query_string() doesn't sound quite right.  What does
that function do, anyway?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company