Horton
Menu

Re: RecordTransactionCommit() and SharedInvalidationMessages

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2010-08-13T16:01:24Z
Lists: pgsql-hackers 
On Thu, Aug 12, 2010 at 9:43 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Fri, Aug 13, 2010 at 10:24 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>>>>>> It appears to me that RecordTransactionCommit() only needs to WAL-log
>>>>>>> shared invalidation messages when wal_level is hot_standby, but I
>>>>>>> don't see a guard to prevent it from doing it in all cases.
>>>> Should use XLogStandbyInfoActive() macro, for the sake of consistency.
>>> And, RelcacheInitFileInval should be initialized with false just in case.
>>
>> How about this?
>
> Looks good to me.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company