Re: review: FDW API
Itagaki Takahiro <itagaki.takahiro@gmail.com>
From: Itagaki Takahiro <itagaki.takahiro@gmail.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Shigeru HANADA <hanada@metrosystems.co.jp>, Jan Urbański <wulczer@wulczer.org>, Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2011-01-24T08:29:33Z
Lists: pgsql-hackers
On Sat, Jan 22, 2011 at 07:20, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes: >> * I wonder if CREATE FOREIGN DATA WRAPPER should automatically create >> the handler function, if it doesn't exist yet. > > Doing that would require the equivalent of pg_pltemplate for FDWs, no? > I think we're a long way from wanting to do that. Also, it seems to me > that add-on FDWs are likely to end up getting packaged as extensions, The proposed file_fdw.sql actually creates a default FDW on installation. So I think the installation scripts work as a template even if we don't have FDW template catalogs. + /* contrib/file_fdw/file_fdw.sql.in */ + -- create wrapper with validator and handler + CREATE OR REPLACE FUNCTION file_fdw_validator (text[], oid) + CREATE OR REPLACE FUNCTION file_fdw_handler () + CREATE FOREIGN DATA WRAPPER file_fdw + VALIDATOR file_fdw_validator HANDLER file_fdw_handler; -- Itagaki Takahiro