Re: pl/python explicit subtransactions
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Steve Singer <ssinger_pg@sympatico.ca>, Jan Urbański <wulczer@wulczer.org>, Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2011-02-26T05:12:36Z
Lists: pgsql-hackers
On Wed, Feb 9, 2011 at 5:22 PM, Peter Eisentraut <peter_e@gmx.net> wrote: > On tis, 2011-02-08 at 00:32 -0500, Steve Singer wrote: >> On 11-02-06 11:40 AM, Jan Urbański wrote: >> >> > PFA an updated patch with documentation. >> >> > Yeah, changed them. >> >> Those changes look fine. The tests now pass. >> >> I've attached a new version of the patch that fixes a few typos/wording >> issues I saw in the documentation. I also changed the link to the >> python reference manual section on context managers. I think it is >> better to link to that versus the original PEP. >> >> The documentation could probably still use more word-smithing but that >> can happen later. I'm marking this as ready for a committer. > > Is it necessarily a good idea that an explicit subtransaction disables > the implicit sub-subtransactions? It might be conceivable that you'd > still want to do some try/catch within explicit subtransactions. Is this still an open question, or what is the remaining issue that needs to be addressed with regards to this patch? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company