Re: psql \conninfo command (was: Patch: psql \whoami option)

On Wed, Jul 21, 2010 at 11:13 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Thu, Jul 22, 2010 at 11:57 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> Should we be using is_absolute_path() here instead, as libpq does?
>
> Yes. The attached patch does that.
>
>>> On Wed, Jul 21, 2010 at 10:09 PM, David Christensen <david@endpoint.com> wrote:
>>> If we print the local socket when it's been explicitly set via the host= param, why not display the actual socket path in the general local socket case?
>>
>> Patch?
>
> Done. DEFAULT_PGSOCKET_DIR (i.e., /tmp) should be displayed in that
> case, I think.
>
>    $ psql -c"\conninfo"
>    You are connected to database "postgres" via local socket on
> "/tmp" at port "5432" as user "postgres".

Sorry for the slow response, I've been slightly buried.

I've committed this with some kibitzing, the most relevant bit of
which is that I changed "via local socket on" to "via local socket
in", which I think reads better.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company