Re: knngist - 0.8

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>, Paul Ramsey <pramsey@cleverelephant.ca>, Tom Lane <tgl@sss.pgh.pa.us>, Teodor Sigaev <teodor@sigaev.ru>, Oleg Bartunov <oleg@sai.msu.su>, Pgsql Hackers <pgsql-hackers@postgresql.org>

Date: 2010-10-18T19:36:51Z

Lists: pgsql-hackers

On Mon, Oct 18, 2010 at 3:33 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On mån, 2010-10-18 at 11:41 +0100, Mark Cave-Ayland wrote:
>> Paul Ramsey wrote:
>>
>> >> So what kind of data structure would you like for a typmod?
>> >
>> > I'm a primitive enough beast that just having 64-bits would make me
>> > happy. As a general matter though, a bytea?
>> >
>> > P
>>
>> For my vote, I'd prefer either the Oid of a custom type or an array of
>> Oid, Datum pairs - i.e. something we can extend in the future if required.
>
> I think if we really wanted to design this generally, we'd give a type
> function arguments.  So, numeric would get (int default = 0, int default
> = 0).  That can easily get very complicated, of course.
>
> In any case, for the shorter term, it's clear that refactoring the
> passing around of type + typmod would help this endeavor, so I'm going
> to give it a try.

By "this endeavor" do you mean KNNGIST, or per-column collation?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company