Re: string function - "format" function proposal
Pavel Stehule <pavel.stehule@gmail.com>
From: Pavel Stehule <pavel.stehule@gmail.com>
To: Itagaki Takahiro <itagaki.takahiro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@commandprompt.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2010-09-09T11:57:41Z
Lists: pgsql-hackers
Attachments
- format.diff (text/x-patch) patch
- stringfunc.diff (text/x-patch) patch
Hello I am sending a updated version. changes: * tag %v removed from format function, * proprietary tags %lq a iq removed from sprintf * code cleaned patch divided to two parts - format function and stringfunc (contains sprintf function and substitute function) Regards Pavel Stehule 2010/9/6 Pavel Stehule <pavel.stehule@gmail.com>: > 2010/9/6 Itagaki Takahiro <itagaki.takahiro@gmail.com>: >> On Mon, Sep 6, 2010 at 11:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> So? You'd need to quote the values anyway, in general. If you want >>> something that will be valid SQL you'd better include the functionality >>> of quote_literal() in it. >>> >>> I'm not sure that it's a good idea to have any type-specific special >>> cases. >> >> As I remember, the original motivation of %v formatter is >> some DBMSes don't like quoted numeric literals. However, >> Postgres accepts quoted numerics, and we're developing Postgres. >> >> So, our consensus would be %v formatter should be removed >> completely from the format function. >> > > I think so tag that quotes all without numbers can be very useful, but > it isn't too much important for me. I can live without them. > > Regards > > Pavel > >> -- >> Itagaki Takahiro >> >