Re: including backend ID in relpath of temp rels - updated patch
Jaime Casanova <jaime@2ndquadrant.com>
From: Jaime Casanova <jaime@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2010-07-29T06:56:16Z
Lists: pgsql-hackers
On Sun, Jul 25, 2010 at 4:32 PM, Robert Haas <robertmhaas@gmail.com> wrote: > On Sun, Jul 25, 2010 at 2:37 AM, Jaime Casanova <jaime@2ndquadrant.com> wrote: >> but i have a few questions, maybe is right what you did i only want to >> understand it: >> - you added this in include/storage/smgr.h, so why is safe to assume >> that if the backend != InvalidBackendId it must be a temp relation? >> >> +#define SmgrIsTemp(smgr) \ >> + ((smgr)->smgr_rnode.backend != InvalidBackendId) > > That's pretty much the whole point of the patch. Instead of > identifying relations as simply "temporary" or "not temporary", we > identify as "a temporary relation owned by backend X" or as "not > temporary". > Ok, this one seems good enough... i'm marking it as "ready for committer" -- Jaime Casanova www.2ndQuadrant.com Soporte y capacitación de PostgreSQL