Re: Review: Patch for phypot - Pygmy Hippotause
Andrew Geery <andrew.geery@gmail.com>
From: Andrew Geery <andrew.geery@gmail.com>
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, plm@netspace.net.au, pgsql-hackers@postgresql.org
Date: 2010-07-24T10:47:32Z
Lists: pgsql-hackers
It looks good to me: (0) new patch applies cleanly to CVS HEAD; (1) the formating of the code was changed; (2) definition of the HYPOT macro was changed to use phypot rather than being removed; (3) the phypot function was declared to be extern; (4) the comments to the phypot function were changed to remove the reference about the SUS behavior. I changed the status to "Ready for Committer". Thanks Andrew On Fri, Jul 23, 2010 at 4:01 PM, Kevin Grittner <Kevin.Grittner@wicourts.gov> wrote: > Tom Lane <tgl@sss.pgh.pa.us> wrote: > >> I think the patch is good in principle > > Since everyone seems to agree this is a good patch which needed > minor tweaks, and we haven't heard from the author, I just went > ahead and made the changes. > > Andrew, could you take another look and see if you agree I've > covered it all before it gets marked ready for a committer? > > -Kevin >