Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch

Andrew Geery <andrew.geery@gmail.com>

From: Andrew Geery <andrew.geery@gmail.com>

To: Bernd Helmle <mailings@oopsware.de>

Cc: Alvaro Herrera <alvherre@commandprompt.com>, Dean Rasheed <dean.a.rasheed@gmail.com>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2010-10-15T13:26:52Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Catalog NOT NULL constraints
- e056c557aef4 16.0 landed

The new patch applies cleanly to head, there are no compile errors and
all the make check tests pass (linux).

Thanks
Andrew

On Thu, Oct 14, 2010 at 4:35 PM, Bernd Helmle <mailings@oopsware.de> wrote:
>
>
> --On 14. Oktober 2010 16:28:51 -0300 Alvaro Herrera
> <alvherre@commandprompt.com> wrote:
>
>>> Looking in that function, there is a similar "found" variable that
>>> isn't being initialised (which my compiler didn't warn about).
>>> Initialising that to false, sems to fix the problem and all the
>>> regression tests then pass.
>>
>> Excellent.  Please send an updated patch.
>
> Here is an updated version of the patch. It fixes the following issues
> Andrew discovered during his review cycle:
>
> * Fix compiler warnings and crash due to uninitialized variables (pretty
> much the fix Dean proposed)
>
> * Remove accidentally added pg_latch.c in my own git repos.
>
> I will do further cycles over Andrew's review report.
>
> --
> Thanks
>
>        Bernd