Re: refactoring comment.c

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Alvaro Herrera <alvherre@commandprompt.com>, Kevin Grittner <kevin.grittner@wicourts.gov>, Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2010-08-28T02:42:12Z

Lists: pgsql-hackers

On Fri, Aug 27, 2010 at 9:49 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> What's a bit odd about this is that I do get warnings for this kind of
>> thing in general, which get turned into errors since I compile with
>> -Werror; and in fact the version of the patch that I committed has no
>> fewer than four places where there is a comment that says "placate
>> compiler".  But for some reason the compiler I used to develop this
>> patch (gcc-4.2.1 i686-apple-darwin10) did not complain about this
>> case, for reasons that are not quite clear to me.
>
> gcc has been able to detect possibly-uninitialized scalar variables
> for many years, but only fairly-recent versions seem to apply the
> same type of logic to fields of local structs.

I thought it might be something like that.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company